Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fit page to window reader setting #323

Merged
merged 3 commits into from
Jun 3, 2023
Merged

Conversation

Alexandre-P-J
Copy link
Contributor

Description

The following change adds a new option to the reader settings called fit page to window. This feature allows users to display pages maximally fitted to the reader window without overflowing vertical or horizontaly.
The behavior is similar to the current page fitting of the two-page or horizontal scroll reader modes. The reader style where the change makes more sense is in both single page modes but it is also useful in webtoon and continues vertical modes.

Before the change (identical to having the setting disabled)

Single page

image

Vertical

image

After the change: Disabled

Single page

image

Vertical

image

After the change: Enabled

Single page

image

Vertical

image

Copy link
Collaborator

@schroda schroda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as you've mentioned in discord, I'd say the setting should be hidden for reader modes where it doesn't do anything

@Alexandre-P-J
Copy link
Contributor Author

This last commit also hides the option in reader modes where it doesn't do anything.

@Alexandre-P-J Alexandre-P-J requested a review from schroda June 3, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants