App strings reworked #277
App strings reworked #277
Conversation
src/i18n/locale/en.json
Outdated
| @@ -8,19 +8,19 @@ | |||
| }, | |||
| "error": { | |||
| "label": { | |||
| "empty": "Category is Empty", | |||
| "empty": "Empty Category", | |||
There was a problem hiding this comment.
| "empty": "Empty Category", | |
| "empty": "Empty category", |
?
There was a problem hiding this comment.
don't change this, this is a message shown to the user when a category is empty.
src/i18n/locale/en.json
Outdated
| @@ -8,19 +8,19 @@ | |||
| }, | |||
| "error": { | |||
| "label": { | |||
| "empty": "Category is Empty", | |||
| "empty": "Empty Category", | |||
There was a problem hiding this comment.
don't change this, this is a message shown to the user when a category is empty.
src/i18n/locale/en.json
Outdated
| "continuous_horizontal_ltr": "Horizontal (LTR) →", | ||
| "continuous_horizontal_rtl": "Horizontal (RTL) ←", |
There was a problem hiding this comment.
nice touch, maybe we could use emoji?
There was a problem hiding this comment.
Certainly. It may also be possible to find something for "double page".
There was a problem hiding this comment.
do we really want to have the icon/emoji in the translations? wouldn't it be better to add it in the code?
There was a problem hiding this comment.
Would end up on the wrong side RTL if done on the backend?
There was a problem hiding this comment.
you're right, didn't think about that
src/i18n/locale/en.json
Outdated
| }, | ||
| "title": "Backup" | ||
| }, | ||
| "label": { | ||
| "dark_theme": "Dark Theme", | ||
| "image_cache": "Use image cache", | ||
| "image_cache_description": "Disabling image cache makes images load faster if you have a slow disk, but uses it much more internet traffic in turn", | ||
| "image_cache_description": "Preloading images shows them quicker, but downloads more data.", |
There was a problem hiding this comment.
It was confusing as it was, now its worse
There was a problem hiding this comment.
I'm also unaware that the cache has something to do with preloading?
regarding the old description, I don't think any disk (unless broken) will actually have any impact.
so the only change I see, is that the images will always be freshly loaded from the source
There was a problem hiding this comment.
regarding the nouns, the correct spelling should be in lower case @AriaMoradi
src/i18n/locale/en.json
Outdated
| "by_date_added": "By Date Added", | ||
| "by_last_read": "By Last Read", | ||
| "by_unread_chapters": "By Unread chapters" | ||
| "by_unread_chapters": "By Unread Chapters" |
There was a problem hiding this comment.
imo that should be all lowercase letters (e.g. "By date added")
src/i18n/locale/en.json
Outdated
| }, | ||
| "title": "Backup" | ||
| }, | ||
| "label": { | ||
| "dark_theme": "Dark Theme", | ||
| "image_cache": "Use image cache", | ||
| "image_cache_description": "Disabling image cache makes images load faster if you have a slow disk, but uses it much more internet traffic in turn", | ||
| "image_cache_description": "Preloading images shows them quicker, but downloads more data.", |
There was a problem hiding this comment.
I'm also unaware that the cache has something to do with preloading?
regarding the old description, I don't think any disk (unless broken) will actually have any impact.
so the only change I see, is that the images will always be freshly loaded from the source
|
Fixes https://hosted.weblate.org/translate/suwayomi/tachidesk-webui/en/?checksum=1cf13a44200b216e
spotted by @NathanBnm