Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cleanup] Add enums and types #257

Merged
merged 2 commits into from
Apr 20, 2023
Merged

[Cleanup] Add enums and types #257

merged 2 commits into from
Apr 20, 2023

Conversation

schroda
Copy link
Collaborator

@schroda schroda commented Mar 6, 2023

No description provided.

Copy link
Member

@AriaMoradi AriaMoradi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I would keep extension state as lowercase and make it look uppercase with css

@schroda
Copy link
Collaborator Author

schroda commented Apr 9, 2023

that is actually not the text that gets rendered, looks like I've missed some hardcoded strings in langauge.tsx ISOLanguages

I'll fix/improve it in another pr

@schroda
Copy link
Collaborator Author

schroda commented Apr 16, 2023

added the changes to this pr

extracted the "default languages" (all, other, local source) from the "ISOLanguages" and also translating them using i18n

@AriaMoradi
Copy link
Member

AriaMoradi commented Apr 16, 2023

We have to merge and lock translation strings before merging commits on the main repo and then pull on weblate.
Notify me before merging this kind of PR.

The "default languages" will also be translated depending on which language the user selected
@schroda schroda merged commit 0a56a2f into Suwayomi:master Apr 20, 2023
@schroda schroda deleted the feature/extensions_cleanup branch April 20, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants