Feature/extension card cleanup #252
Conversation
| break; | ||
| case 'uninstall': | ||
| uninstall(); | ||
| case ExtensionState.OBSOLETE: |
There was a problem hiding this comment.
@schroda I wanted to know if this is the same mechanism used in the tachiyomi app. Last time this happend it was confusing to me. When I clicked on the obsolete button it started to uninstall the extension. Should we change this behaviour so that the user knows what they are doing by clicking on this?
Maybe just saying that the extension is obsolete as a label and then giving the uninstall button should work. I remember tachiyomi app doing that once, long time ago
There was a problem hiding this comment.
no idea how that works in tachiyomi, never used that app
Maybe just saying that the extension is obsolete as a label and then giving the uninstall button should work. I remember tachiyomi app doing that once, long time ago
another option could also be to add a group "Obsolote" (or some other name) in the "Source" screen and have the "action" be "Uninstall"
but this can/should be done in a separate pr
There was a problem hiding this comment.
Agreed, this should be taken up in another PR, rest of the things look good. I will open an issue for this
preparation for i18n usage + cleanup