Switch from chrono to time 0.3.3 to avoid vulns #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjg
force-pushed
the
switch-chrono-to-time
branch
2 times, most recently
from
65edb9d to
d033071
Compare
Codecov Report
@@ Coverage Diff @@
## master #297 +/- ##
==========================================
- Coverage 80.79% 80.78% -0.02%
==========================================
Files 56 56
Lines 5317 5318 +1
==========================================
Hits 4296 4296
- Misses 1021 1022 +1
Continue to review full report at Codecov.
|
Stranger6667
requested changes
Oct 20, 2021
Due to a CVE in chrono[0] we switch to time 0.3.3. Chrono actually depends on an older, similarly vulnerable version of `time` but newer versions of `time` seem to offer everything we need to validate dates and times anyway. [0] rustsec/advisory-db#1082 Signed-off-by: Alex Good <alex@memoryandthought.me>
alexjg
force-pushed
the
switch-chrono-to-time
branch
from
d033071 to
00f4503
Compare
Stranger6667
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a CVE in chrono[0] we switch to time 0.3.3. Chrono actually
depends on an older, similarly vulnerable version of
timebut newerversions of
timeseem to offer everything we need to validate datesand times anyway.
[0] rustsec/advisory-db#1082
Signed-off-by: Alex Good alex@memoryandthought.me