Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabling population of individual namelist parameters #1355

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from
Draft

Enabling population of individual namelist parameters #1355

wants to merge 13 commits into from

Conversation

jasonfleming
Copy link
Collaborator

resolves #1354 ... testing this now

@jasonfleming jasonfleming requested a review from wwlwpd July 28, 2024 20:56
@wwlwpd
Copy link
Collaborator

wwlwpd commented Jan 28, 2025 •
edited
Loading

@jasonfleming - let's talk, what about an approach like this - f976675, where we just expose the settings in the mesh_defaults.sh? disregard

@jasonfleming
Copy link
Collaborator Author

Ok I think this is working except for defining the ADCIRC version support for various features. Let's discuss next time we meet.

@jasonfleming
resolves #1354

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
8f1ddb1
@jasonfleming
Start of adcirc version support
ce51d57
@wwlwpd
Copy link
Collaborator

wwlwpd commented Feb 4, 2025

Ok I think this is working except for defining the ADCIRC version support for various features. Let's discuss next time we meet.

@jasonfleming remind me, was there anything actionable for me on this other than a review when you marked it ready?

@jasonfleming
Copy link
Collaborator Author

Hey @wwlwpd I am adding/consolidating/refactoring some of this as well as adding tests. Nothing for you to do until this is ready. Hope to finish implementation and testing by Monday.

wwlwpd
wwlwpd approved these changes Mar 3, 2025
View reviewed changes
Copy link
Collaborator

@wwlwpd wwlwpd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of good looking work, looks fine to me!

@wwlwpd
Copy link
Collaborator

wwlwpd commented Mar 3, 2025 •
edited
Loading

After this I should jump on asgs-lint work since we'll have official adcircVersions to compare - #1439

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wwlwpd wwlwpd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable control_file_gen.pl to populate namelist parameters individually
2 participants
@jasonfleming @wwlwpd