Skip to content

I added permissions and bugfixed the interdimensonal graving #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

JustusJG
Copy link
Contributor

Also I learned pull request :)

@StoneLabs StoneLabs added enhancement New feature or request modded Related to other mods labels May 13, 2024
@StoneLabs
Copy link
Owner

StoneLabs commented Jun 14, 2024

Ill close this for now and use your code as future reference when i implement them, thanks :)
(youll be coauthered on the commits ofc)

For future reference since you are new to git and github a friendly tip:
Try to only do one thing per PR. For example: One PR for the permissions, one PR for public/private graves and one for flexible grave keys. That way parts can be merged individually easily. Keep at it, git is difficult but once you get the hang its great! 👍

edit/ If you'd like you can open a new PR for the permissions API changes (and nothing else) :)

@StoneLabs StoneLabs added the plural Multiple changes in one PR, closed. label Jun 14, 2024
@StoneLabs StoneLabs closed this Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request modded Related to other mods plural Multiple changes in one PR, closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants