Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

texter todos: gather unassigned checks into a single query instead of per-assignment #1972

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

schuyler1d
Copy link
Collaborator

Description

Makes queries for dynamic assignment info more efficient -- instead of a sql query for each assignment, it does them all at once

Checklist:

  • I have manually tested my changes on desktop and mobile
  • The test suite passes locally with my changes
  • If my change is a UI change, I have attached a screenshot to the description section of this pull request
  • My change is 300 lines of code or less, or has a documented reason in the description why it’s longer
  • I have made any necessary changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • My PR is labeled [WIP] if it is in progress

@schuyler1d schuyler1d added the S-ready for stage-main (qa) Status (ADMINS ONLY): PR label for those ready to be added for stage: Approved, tests, etc label Apr 9, 2021
@ibrand ibrand temporarily deployed to spoke-review-todos-bulk-goqh3f April 9, 2021 17:59 Inactive
@schuyler1d schuyler1d merged commit 1fe295e into main Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-ready for stage-main (qa) Status (ADMINS ONLY): PR label for those ready to be added for stage: Approved, tests, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants