Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to also suppress Tags in Message Review #1967

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

codygordon
Copy link
Collaborator

@codygordon codygordon commented Mar 28, 2021

Description

Partial implementation of https://github.com/MoveOnOrg/Spoke/issues/1854

Pretty straightforward, adds another section to the Tags dropdown selector in Message Review with another list of tags you can select to be suppressed. Made sure you can't select a tag to filter by and suppress.

Screen Shot 2021-03-28 at 3 32 52 PM

As you can see, one issue I couldn't figure out is why selected "filter by" tag menu items have orange text when checked and the new ones don't. Not a huge deal, just kind of annoying.

Should probably write tests for this functionality, but upon some manual QA it seems to work fine.

Checklist:

  • I have manually tested my changes on desktop and mobile
  • The test suite passes locally with my changes
  • If my change is a UI change, I have attached a screenshot to the description section of this pull request
  • My change is 300 lines of code or less, or has a documented reason in the description why it’s longer
  • I have made any necessary changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • My PR is labeled [WIP] if it is in progress

@codygordon codygordon requested a review from schuyler1d March 28, 2021 22:56
@codygordon codygordon added A-message review Area: Message review improvement or bug C-enhancement Type: enhancement labels Mar 29, 2021
@schuyler1d schuyler1d added the S-ready for stage-main (qa) Status (ADMINS ONLY): PR label for those ready to be added for stage: Approved, tests, etc label Mar 30, 2021
@schuyler1d schuyler1d merged commit 1505fc8 into StateVoicesNational:main Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-message review Area: Message review improvement or bug C-enhancement Type: enhancement S-ready for stage-main (qa) Status (ADMINS ONLY): PR label for those ready to be added for stage: Approved, tests, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants