Add ability to also suppress Tags in Message Review #1967
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partial implementation of https://github.com/MoveOnOrg/Spoke/issues/1854
Pretty straightforward, adds another section to the
Tags
dropdown selector inMessage Review
with another list of tags you can select to be suppressed. Made sure you can't select a tag to filter by and suppress.As you can see, one issue I couldn't figure out is why selected "filter by" tag menu items have orange text when checked and the new ones don't. Not a huge deal, just kind of annoying.
Should probably write tests for this functionality, but upon some manual QA it seems to work fine.
Checklist: