Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScriptEditor cursor position #1926

Merged
merged 1 commit into from
Apr 13, 2021
Merged

ScriptEditor cursor position #1926

merged 1 commit into from
Apr 13, 2021

Conversation

stefanhayden
Copy link
Collaborator

@stefanhayden stefanhayden commented Feb 10, 2021 •
edited
Loading

Description

When opening the ScriptEditor the cursor should be at the end of the text in the input. Starting the cursor at the beginning of the input feels awkward and makes it harder to open the editor and start typing.

OLD
image

NEW
image

Checklist:

  • I have manually tested my changes on desktop and mobile
  • The test suite passes locally with my changes
  • If my change is a UI change, I have attached a screenshot to the description section of this pull request
  • My change is 300 lines of code or less, or has a documented reason in the description why it’s longer
  • I have made any necessary changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • My PR is labeled [WIP] if it is in progress

schuyler1d
schuyler1d approved these changes Mar 10, 2021
View reviewed changes
Copy link
Collaborator

@schuyler1d schuyler1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@schuyler1d schuyler1d added the S-ready for stage-main (qa) Status (ADMINS ONLY): PR label for those ready to be added for stage: Approved, tests, etc label Mar 10, 2021
@schuyler1d schuyler1d mentioned this pull request Mar 10, 2021
Merged
@schuyler1d schuyler1d merged commit b4f7e40 into StateVoicesNational:main Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schuyler1d schuyler1d schuyler1d approved these changes

Assignees
No one assigned
Labels
S-ready for stage-main (qa) Status (ADMINS ONLY): PR label for those ready to be added for stage: Approved, tests, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanhayden @schuyler1d