Stage phone number management and campaign messaging service changes #1557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Campaign is not available on local machine, and dev tools isn't available on the production machine, so use messagingServiceSid instead
Right now this writes fake data rather than talking to twilio
…number-management
…oke6-phonenumber-management
schuyler1d
added
the
S-ready for stage-main (qa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
#1518 #1495 #1464
Description
This adds two experimental features to the 6.0 release:
Phone number inventory management
Adds functionality to buy Twilio phone numbers directly through the Admin interface. Organizations using their own Messaging Service, i.e. those that have
TWILIO_MESSAGE_SERVICEset in organization features rather than through the global env var, can add the numbers directly to their Messaging Service and use them for texting. Additionally, phone numbers purchased through Spoke can be configured to use a custom voice response by setting theTWILIO_VOICE_URLsetting. A typical use case would be to use TwiML Bins to re-route calls or to play a custom voicemails.Configuration:
EXPERIMENTAL_PHONE_INVENTORYto enable the featureTWILIO_VOICE_URLfor a custom voice responsePer-campaign Twilio Messaging Services
This feature lays the foundation for scaling Spoke on Twilio by allowing campaigns to use their own Messaging Services. When enabled, the campaign edit screen will allow admins to either supply a Messaging Service for the campaign to use or to have Spoke create one for them. Note that numbers will have to be added to the Messaging Service manually. This feature will be integrated with the phone number inventory in a future release.
Configuration:
EXPERIMENTAL_TWILIO_PER_CAMPAIGN_MESSAGING_SERVICEto enableTWILIO_BASE_CALLBACK_URLto configure webhooks for Messaging Services created by Spoke. Required if this feature is enabled.Checklist: