Replace old texter ui with new one with env var: DEPRECATED_TEXTERUI=GONE_SOON #1506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schuyler1d
added
S-on deck
schuyler1d
removed
the
S-ready for stage-main (qa)
ibrand
approved these changes
Apr 30, 2020
schuyler1d
added
S-ready for stage-main (qa)
Co-authored-by: Ilona Brand <theilonabrand@gmail.com>
|
This was merged through a different branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1493
Description
While #1496 can be merged without changing the current interface, and just allows the new one with ?new=1 in the url, this one makes the new interface the default. You can get to the old one manually by adding ?old=1 to a texter url or set environment variable
DEPRECATED_TEXTERUI=GONE_SOONto enable it.This will be removed in a later release, but is meant to give time to update training materials and fallback, in case a major regression is found.