Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1362] Feature Request: Change the label on the "Send Replies" button #1489

Closed
wants to merge 2 commits into from
Closed

[1362] Feature Request: Change the label on the "Send Replies" button #1489

wants to merge 2 commits into from

Conversation

larkinds
Copy link
Collaborator

@larkinds larkinds commented Apr 17, 2020 •
edited
Loading

Fixes # #1362

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change, and any blockers that make your change a WIP

Checklist:

  • I have manually tested my changes on desktop and mobile
  • The test suite passes locally with my changes
  • If my change is a UI change, I have attached a screenshot to the description section of this pull request

Screen Shot 2020-04-17 at 3 03 38 PM

  • My change is 300 lines of code or less, or has a documented reason in the description why it’s longer
  • I have made any necessary changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • My PR is labeled [WIP] if it is in progress

@larkinds larkinds closed this Apr 17, 2020
@larkinds larkinds reopened this Apr 17, 2020
ibrand
ibrand approved these changes Apr 17, 2020
View reviewed changes
Copy link
Collaborator

@ibrand ibrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ibrand ibrand added the S-on deck Status (ADMINS ONLY): PR label for those that will be added to the next stage label Apr 30, 2020
@schuyler1d schuyler1d added S-ready for stage-main (qa) Status (ADMINS ONLY): PR label for those ready to be added for stage: Approved, tests, etc and removed S-on deck Status (ADMINS ONLY): PR label for those that will be added to the next stage labels May 6, 2020
@schuyler1d schuyler1d mentioned this pull request May 6, 2020
Merged
@ibrand
Copy link
Collaborator

ibrand commented May 28, 2020

Fixed in v6.0

@ibrand ibrand closed this May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrand ibrand ibrand approved these changes

Assignees
No one assigned
Labels
S-ready for stage-main (qa) Status (ADMINS ONLY): PR label for those ready to be added for stage: Approved, tests, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@larkinds @ibrand @schuyler1d