Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid printing messages to the console. #365

Merged
merged 1 commit into from
Mar 31, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,18 @@ GitHub.dart is committed to efficiency as much as possible. If your code is not

Pull Request rejections are not a bad thing. It just means you need to fix something. Perhaps it is important to define 'rejection' as it is used in this case. A rejection is when a GitHub.dart committer comments on a Pull Request with a comment like 'rejected due to incorrect formatting'.

## Tests

To run the complete test suite you will need to install
`octokit/fixtures-server`.

```
npm install --global @octokit/fixtures-server
```

Tests can be run using `make test`, which will start up a local mock
GitHub and execute tests against it using your localhost port 3000.

## Contacting Us

- IRC: `#directcode on irc.esper.net and irc.freenode.net`
Expand Down
3 changes: 1 addition & 2 deletions lib/src/common/github.dart
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,6 @@ class GitHub {
/// Internal method to handle status codes
///
Never handleStatusCode(http.Response response) {
print(response.body);
String? message = '';
List<Map<String, String>>? errors;
if (response.headers['content-type']!.contains('application/json')) {
Expand All @@ -450,7 +449,7 @@ class GitHub {
}
}
} catch (ex) {
print(ex);
throw UnknownError(this, ex.toString());
}
}
switch (response.statusCode) {
Expand Down