-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose CheckSuitesService and ChuckRunsService classes #351
Conversation
Require Dart 2.18 Also a bunch of other cleanup, enabled latest lints removed duplicate lints sorted lints etc
Also takes care of #345 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -1,397 +1,61 @@ | |||
include: package:lints/recommended.yaml | |||
|
|||
analyzer: | |||
strong-mode: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you!
@@ -11,21 +11,21 @@ class ChecksService extends Service { | |||
/// Methods to interact with Check Runs. | |||
/// | |||
/// API docs: https://developer.github.com/v3/checks/runs/ | |||
final _CheckRunsService checkRuns; | |||
final CheckRunsService checkRuns; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some of my own code to cleanup now :-)
@@ -1,4 +1,4 @@ | |||
var getBlob = ''' | |||
String getBlob = ''' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these be final?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or const?
Also a bunch of other cleanup, enabled latest lints
removed duplicate lints
sorted lints
etc