Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose CheckSuitesService and ChuckRunsService classes #351

Merged
merged 3 commits into from
Feb 3, 2023
Merged

Conversation

kevmoo
Copy link
Collaborator

@kevmoo kevmoo commented Feb 3, 2023

Also a bunch of other cleanup, enabled latest lints
removed duplicate lints
sorted lints
etc

@kevmoo kevmoo added no_release_on_merge Skip releasing when merged and removed unreleased labels Feb 3, 2023
@kevmoo kevmoo requested a review from CaseyHillers February 3, 2023 01:51
@kevmoo kevmoo added the semver:minor Non-Breaking Public API Changes (additions) label Feb 3, 2023
Require Dart 2.18
Also a bunch of other cleanup, enabled latest lints
removed duplicate lints
sorted lints
etc
@kevmoo
Copy link
Collaborator Author

kevmoo commented Feb 3, 2023

Also takes care of #345

@kevmoo kevmoo requested a review from robrbecker February 3, 2023 01:58
Copy link
Collaborator

@CaseyHillers CaseyHillers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -1,397 +1,61 @@
include: package:lints/recommended.yaml

analyzer:
strong-mode:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@@ -11,21 +11,21 @@ class ChecksService extends Service {
/// Methods to interact with Check Runs.
///
/// API docs: https://developer.github.com/v3/checks/runs/
final _CheckRunsService checkRuns;
final CheckRunsService checkRuns;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some of my own code to cleanup now :-)

@@ -1,4 +1,4 @@
var getBlob = '''
String getBlob = '''
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these be final?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or const?

@kevmoo kevmoo merged commit 5e64d59 into master Feb 3, 2023
@kevmoo kevmoo deleted the cleanup branch February 3, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no_release_on_merge Skip releasing when merged semver:minor Non-Breaking Public API Changes (additions) unreleased
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants