Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add review information to PullRequest #268

Merged
merged 2 commits into from
Oct 11, 2021
Merged

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented Oct 8, 2021

Fixes #267

This adds review information to PullRequest. I am gong to be using this to automate a review manager bot.

@robrbecker
Copy link
Member

Thanks for putting up a PR! While reviewing I realized that a number of fields are not named in such a way as to map to the correct github field. requestedReviewers will map to requested_reviewers, which is correct. But reviewCommentCount will map to review_comment_count when the name in the response is review_comments. There are other count fields that look to be incorrect as well 😬
image

So, I'm going to go ahead and merge this, but then follow up with fixes for this and other fields that are wrong. In this case you'd just need something like:

  @JsonKey(name: 'review_comments')
  int? reviewCommentCount;

@robrbecker robrbecker merged commit b89a03f into SpinlockLabs:master Oct 11, 2021
@robrbecker
Copy link
Member

@Piinks give version 8.2.0 a try https://github.com/SpinlockLabs/github.dart/releases/tag/8.2.0

@Piinks
Copy link
Contributor Author

Piinks commented Oct 11, 2021

Sweet! Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request for review information on PullRequest
3 participants