Fix full paths in ProtoDeclaration implementions
#329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #329 +/- ##
============================================
- Coverage 76.29% 76.07% -0.23%
Complexity 558 558
============================================
Files 190 192 +2
Lines 4143 4158 +15
Branches 388 392 +4
============================================
+ Hits 3161 3163 +2
- Misses 852 863 +11
- Partials 130 132 +2 |
armiol
approved these changes
Feb 20, 2025
| @@ -0,0 +1,53 @@ | |||
| /* | |||
| * Copyright 2024, TeamDev. All rights reserved. | |||
| @@ -14,6 +14,10 @@ option java_multiple_files = true; | |||
| import "google/protobuf/timestamp.proto"; | |||
| import "spine/protodata/ast.proto"; | |||
|
|
|||
| message Project { | |||
There was a problem hiding this comment.
Couldn't quickly find if it is used. Just saying. Looks a bit odd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes setting absolute file paths in
MessageType,EnumType, andService. Previously, only events related to the declarations and file headers had full paths.