Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON Compilation Database: support case sensitive filesystems #2725

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

guwirth
Copy link
Collaborator

@guwirth guwirth commented Aug 23, 2024

Depending on whether the filesystem is case sensitive or case insentitive, paths/comparisons of paths must be handled differently.


This change is Reviewable

@guwirth guwirth added the bug label Aug 23, 2024
@guwirth guwirth added this to the 2.1.3 milestone Aug 23, 2024
@guwirth guwirth self-assigned this Aug 23, 2024
@guwirth guwirth force-pushed the json-db-filenames branch from 8557fdf to 663e5f5 Compare August 23, 2024 13:31
Depending on whether the file system is case sensitive or case insentitive, paths/comparisons of paths must be handled differently.
- case sensitive: (default Linux): Paths must not be changed.
- case insentitive (default Windows):  Here, paths in reports from tools are often stored with lower case letters. The original spelling in the file system must be restored before a path comparison.
- add additional integration test samples for Windows/Linux using upper case filenames
- close SonarOpenCommunity#2691
@guwirth guwirth force-pushed the json-db-filenames branch from a947a6c to 20c54bf Compare August 27, 2024 08:17
@guwirth guwirth changed the title JSON Compilation Database: support case sensitive paths JSON Compilation Database: support case sensitive filesystems Aug 27, 2024
@guwirth guwirth merged commit f55e1a1 into SonarOpenCommunity:master Aug 27, 2024
15 checks passed
@guwirth guwirth deleted the json-db-filenames branch August 29, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant