Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Visual Studio warnings (VS2019 / msvc-160) #1981

Merged
merged 1 commit into from
Nov 29, 2020
Merged

update Visual Studio warnings (VS2019 / msvc-160) #1981

merged 1 commit into from
Nov 29, 2020

Conversation

guwirth
Copy link
Collaborator

@guwirth guwirth commented Nov 25, 2020 •
edited
Loading

  • Compiler warnings C4000 - C5999
    default 'severity': 'INFO', 'type': 'CODE_SMELL'

  • Code analysis for C/C++ warnings
    default: 'severity': 'CRITICAL', 'type': 'CODE_SMELL'

  • C++ Core Guidelines checker warnings
    default 'severity': 'INFO', 'type': 'CODE_SMELL'

  • Add Python script to read VC messages from web. Unfortunately the warnings are not uniformly structured, which is why some manual rework is often necessary.

  • close Missing VC rules #1488

This change is Reviewable

@guwirth guwirth added this to the 2.0.0 milestone Nov 25, 2020
@guwirth guwirth self-assigned this Nov 25, 2020
@guwirth guwirth changed the title update Visual Studio warnings update Visual Studio warnings (VS2019 / msvc-160) Nov 29, 2020
@guwirth guwirth mentioned this pull request Nov 29, 2020
Closed
@guwirth
update Visual Studio warnings (VS2019 / msvc-160)
318c521 
- Compiler warnings C4000 - C5999
  - default 'severity': 'INFO', 'type': 'CODE_SMELL'
- Code analysis for C/C++ warnings
  - default: 'severity': 'CRITICAL', 'type': 'CODE_SMELL'
- C++ Core Guidelines checker warnings
  - default 'severity': 'INFO', 'type': 'CODE_SMELL'
- add script to read VC messages from web
  - Unfortunately the warnings are not uniformly structured, which is why some manual rework is often necessary.

- close SonarOpenCommunity#1488
@ghost
Copy link

ghost commented Nov 29, 2020

DeepCode's analysis on #318c52 found:

  • ℹ️ 3 minor issues. 👇

Top issues

Description Example fixes
Do not use `len(SEQUENCE)` to determine if a sequence is empty Occurrences: 🔧 Example fixes
Access to a protected member _serialize_xml of a client class Occurrences: 🔧 Example fixes
Two branches in a conditional structure have exactly the same implementation which is likely an error (_ and _) Occurrences: 🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@guwirth guwirth merged commit 652f5e9 into SonarOpenCommunity:master Nov 29, 2020
@guwirth guwirth deleted the vc-warnings branch November 30, 2020 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@guwirth guwirth

Labels
enhancement
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Missing VC rules
1 participant
@guwirth