-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support of Facebook Infer static analyzer #1868
Add support of Facebook Infer static analyzer #1868
Conversation
👉 View analysis in DeepCode’s Dashboard |
Hello @begarcom, Thx for providing this. I will review it ASAP. Regards, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@begarco thanks a lot looks good, well done. I have only one small hint.
cxx-sensors/src/main/java/org/sonar/cxx/sensors/infer/InferParser.java
Outdated
Show resolved
Hide resolved
cxx-sensors/src/main/java/org/sonar/cxx/sensors/infer/CxxInferSensor.java
Outdated
Show resolved
Hide resolved
@begarco to document this feature it would be helpful:
|
@guwirth I push change asap For other questions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@begarco sorry to bother you again. Have one comment, rest looks good.
String.valueOf(issue.getLine()), issue.getQualifier()); | ||
sensor.saveUniqueViolation(cxxReportIssue); | ||
} else { | ||
LOG.debug("Cannot find the file '{}', skipping violations", issue.getFile()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@begarco think this message is wrong? It’s more Invalid infer issue/message...
file as parameter makes also no sense, is null. Would add issue.toString.
@begarco thanks a lot for providing this PR |
Proposed changes
This pull request only adds support of the Infer static analyzer. It is able to import the JSON report containing warnings about potential source of bugs.
Supported version of Infer:
0.17.0
Types of changes
Checklist
This change is