Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove sonar.cxx.cFilesPatterns #1833

Merged
merged 1 commit into from
Mar 21, 2020
Merged

remove sonar.cxx.cFilesPatterns #1833

merged 1 commit into from
Mar 21, 2020

Conversation

guwirth
Copy link
Collaborator

@guwirth guwirth commented Mar 21, 2020

  • we are using for all languages the same parser
  • difference with cFilesPatterns was only to replace C++ keywords with placeholders to treat them different (use them for example as variable names)
  • easier and more transparent solution is to create a header file and use forceIncludes
  • cFilesPatterns support has been removed
  • close Refactoring: sonar.cxx.cFilesPatterns #1105

Sample:

#define alignas __alignas
#define alignof __alignof
#define catch __catch
#define class __class
...

This change is Reviewable

@guwirth guwirth added this to the 2.0.0 milestone Mar 21, 2020
@guwirth guwirth self-assigned this Mar 21, 2020
@ghost
Copy link

ghost commented Mar 21, 2020

Congratulations 🍻. DeepCode analyzed your code in 0.912 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.


☺️ If you want to provide feedback on our bot, here is how to contact us.

- we are using for all languages the same parser
- difference with cFilesPatterns was only to replace C++ keywords with placeholders to treat them different (use them for example as variable names)
- easier and more transparent solution is to create a header file and use forceIncludes
- cFilesPatterns support has been removed

Sample:

#define alignas __alignas
#define alignof __alignof
#define catch __catch
#define class __class
...
@guwirth guwirth merged commit 13c446d into SonarOpenCommunity:master Mar 21, 2020
@guwirth guwirth deleted the remove-cFilesPatterns branch March 22, 2020 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Refactoring: sonar.cxx.cFilesPatterns
1 participant