Correctly Handle relative paths in JSON Compilation Databases #1797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the specification, all paths specified in a JSON Compilation database must either be absolute, or relative to the location given in the directory field. Fixes #1790
…ore platform independent
guwirth
changed the title
|
@tisoft please review. I made it running on base of your proposal. |
tisoft
reviewed
Jan 27, 2020
There was a problem hiding this comment.
Reviewed 1 of 3 files at r1, 8 of 8 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Bertk, @ivangalkin, and @jmecosta)
|
Looks good to me. I have build it locally and it works for me:tm:. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the specification, all paths specified in a JSON Compilation
database must either be absolute, or relative to the location given
in the directory field.
Fixes #1790
Close #1791 & refactoring of include handling: using Path instead of String to be more platform independent
This change is