Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove sensor.customRules support #1781

Merged
merged 1 commit into from
Jan 7, 2020
Merged

remove sensor.customRules support #1781

merged 1 commit into from
Jan 7, 2020

Conversation

guwirth
Copy link
Collaborator

@guwirth guwirth commented Jan 5, 2020


This change is Reviewable

- it's better to keep the built-in repositories up to date
- after SQ core change support was limited to 4k XML data
- users can use cxx 'other' sensor or https://docs.sonarqube.org/latest/analysis/external-issues/

close #1548
@guwirth guwirth added this to the 1.3.2 milestone Jan 5, 2020
@guwirth guwirth self-assigned this Jan 5, 2020
Copy link
Contributor

@Bertk Bertk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jmecosta jmecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 15 of 15 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ivangalkin)

@guwirth guwirth merged commit 1340793 into SonarOpenCommunity:master Jan 7, 2020
@guwirth guwirth mentioned this pull request Feb 10, 2020
@guwirth guwirth deleted the remove-customRules branch February 14, 2020 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Custom rules limited to 4000 chars
4 participants