Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust cppcheck rules with the cppcheck 1.88 #1741

Merged
merged 2 commits into from
Jul 15, 2019

Conversation

ivangalkin
Copy link
Contributor

@ivangalkin ivangalkin commented Jul 12, 2019

Use the up-to-date error descriptions from cppcheck --errorlist

close #1733


This change is Reviewable

Use the up-to-date error descriptions from `cppcheck --errorlist`

close SonarOpenCommunity#1733
@ivangalkin ivangalkin added this to the 1.3.0 milestone Jul 12, 2019
@ivangalkin ivangalkin requested a review from guwirth July 12, 2019 21:50
@ivangalkin ivangalkin self-assigned this Jul 12, 2019
@guwirth
Copy link
Collaborator

guwirth commented Jul 13, 2019

@ivangalkin thanks. I were using this script https://github.com/SonarOpenCommunity/sonar-cxx/blob/master/cxx-sensors/src/tools/generate_cppcheck_resources.sh to create it and added the new rules. How did you do it? Did you a manual compare at the end?

@ivangalkin
Copy link
Contributor Author

@guwirth

Did you a manual compare at the end?

After you run generate_cppcheck_resources.sh there will be an output file called cppcheck-comparison.md. Among others it contains a diff command.

DIFF EXISTING vs GENERATED

meld path/sonar-cxx/cxx-sensors/src/main/resources/cppcheck.xml path/sonar-cxx/cxx-sensors/src/tools/cppcheck.xml.comparable

It helps to identify the diff between the old rules and the new ones. But it's still some manual effort needed.

@guwirth guwirth merged commit 68a5078 into SonarOpenCommunity:master Jul 15, 2019
@guwirth guwirth mentioned this pull request Jul 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Support Cppcheck 1.88
2 participants