Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update clang-tidy rules (Clang 8.0) #1730

Merged
merged 4 commits into from
Jul 11, 2019
Merged

update clang-tidy rules (Clang 8.0) #1730

merged 4 commits into from
Jul 11, 2019

Conversation

stalb
Copy link
Contributor

@stalb stalb commented Jul 5, 2019 •
edited by SonarOpenCommunityAdmin
Loading

This merge request is doing 3 things:

  • update clang-tidy rules:
    • update clang diagnostics rules (23 new rules)
    • update clang-tidy rules (43 new rules)
  • add a new rule for clang warnings without activation switch (see bug clang-tidy: missing rule [clang-diagnostic-warning] #1702)
  • add a template rule in order to update the clang-tidy rule list without rebuilding the pluging

This change is Reviewable

stalb added 4 commits July 5, 2019 22:33
@stalb
update rules for clang warnings (23 new rules)
0a0387f
@stalb
update clang-tidy rules (43 new rules)
79da08a
@stalb
add rule generation for clang warnings without activation switch
5193816 
Clang-tidy uses 3 check names for clang diagnostics without warning
options: [clang-tidy/.../ClangTidyDiagnosticConsumer.cpp](https://github.com/llvm/llvm-project/blob/60e1296a9a36186656989d8223b60b6d4cb67b34/clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp#L434-L448)
* `clang-diagnostic-error` for compiler errors
* `clang-diagnostic-warning` for compiler warnings
* `clang-diagnostic-unknown` for everything else (notes, remarks, ...)

Since the C++ community plugin manage only compiler warnings,
just one rule is added for `clang-diagnostic-warning`.
@stalb
clang-tidy: add template rule generation
f267235
@guwirth guwirth added this to the 1.3.0 milestone Jul 10, 2019
@guwirth guwirth self-requested a review July 10, 2019 20:22
@guwirth
Copy link
Collaborator

guwirth commented Jul 10, 2019

@stalb thanks for providing this update. One question: which clang-tidy version does this new messages belong to?

@stalb
Copy link
Contributor Author

stalb commented Jul 10, 2019

I used the master branch of the git repository of llvm (2019-07-05): llvm/llvm-project@d22b2d01cae

@guwirth
Copy link
Collaborator

guwirth commented Jul 11, 2019

@stalb I always like to write a version number to the sensor: clang tidy version x.xx supported. So if this is the current branch we can use last release? Which version was this?

@guwirth
Copy link
Collaborator

guwirth commented Jul 11, 2019

@stalb can we write Clang 8.0?

@guwirth guwirth merged commit d4c5dc9 into SonarOpenCommunity:master Jul 11, 2019
@guwirth guwirth changed the title update clang-tidy rules update clang-tidy rules (Clang 8.0) Jul 11, 2019
@guwirth guwirth mentioned this pull request Jul 12, 2019
Closed
@guwirth guwirth mentioned this pull request Jul 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guwirth guwirth guwirth approved these changes

Assignees

@stalb stalb

Labels
enhancement
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@stalb @guwirth