Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support real paths in coverage sensor for C++/CLI #1701

Merged
merged 2 commits into from
Apr 14, 2019
Merged

support real paths in coverage sensor for C++/CLI #1701

merged 2 commits into from
Apr 14, 2019

Conversation

guwirth
Copy link
Collaborator

@guwirth guwirth commented Apr 13, 2019

  • move getInputFileIfInProject to CxxReportSensor
  • introduce executeImpl (template method pattern)

solution from @jmecosta #1688 with review comments from @ivangalkin


This change is Reviewable

- move getInputFileIfInProject to CxxReportSensor
- introduce executeImpl (template method pattern)

solution from @jmecosta #1688 with review comments from @ivangalkin
@guwirth guwirth added the bug label Apr 13, 2019
@guwirth guwirth added this to the 1.3.0 milestone Apr 13, 2019
@guwirth guwirth requested review from jmecosta and ivangalkin April 13, 2019 19:54
@guwirth guwirth self-assigned this Apr 13, 2019
@guwirth guwirth merged commit 3491006 into SonarOpenCommunity:master Apr 14, 2019
haghighi pushed a commit to haghighi/sonar-cxx that referenced this pull request Jun 22, 2019
- support all cases of absolute / relative path combinations of `source` tag and `filename` tag
- support special cases like drive letter in `source` tag
- upper/lower case and slash/backslash correction should be done by SonarOpenCommunity#1701
@guwirth guwirth mentioned this pull request Jul 28, 2019
@guwirth guwirth deleted the real_path_coverage branch July 29, 2019 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants