CxxPreprocessor: reduce run-time overhead, extract invariants #1637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were several actions, which were executed for each preprocessed source file Among others all standard macros were re-created for each preprocessor invocation. Create those macros statically in order to reduce the run-time overhead.
|
@ivangalkin not sure if I wanna have it in 1.2.1. Is there a measurable difference in the performance? |
|
@guwirth I haven't measured it (yet). It won't provide any huge boost, but is a right thing to do imho - to make invariants to the constants |
|
@ivangalkin I like to merge it. I'm only not sure if we should do it in 1.2.1. Therefore the question for the risk. |
|
@guwirth this change doesn't introduce any risk; this is refactoring only. I am investigating memory consumption problem. I am sure, that CxxPreprocessor uselessly collects data. I'll provide one more PR soon. That one will be more invasive. |
guwirth
approved these changes
Dec 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were several actions, which were executed for each preprocessed source file
Among others all standard macros were re-created for each preprocessor invocation.
Create those macros statically in order to reduce the run-time overhead.
This change is