Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor refactoring of collections #1618

Merged
merged 1 commit into from
Dec 8, 2018
Merged

minor refactoring of collections #1618

merged 1 commit into from
Dec 8, 2018

Conversation

ivangalkin
Copy link
Contributor

@ivangalkin ivangalkin commented Dec 8, 2018 •
edited by SonarOpenCommunityAdmin
Loading

apply comments from #1611

  • use streams
  • rewrite if (!set.contains(value)) set.add(value) into just set.add(value)
  • minor refactoring

This change is Reviewable

@ivangalkin
minor refactoring of collections
f5f0298 
apply comments from SonarOpenCommunity#1611
* use streams
* rewrite `if (!set.contains(value)) set.add(value)` into just `set.add(value)`
* minor refactoring
@ivangalkin ivangalkin added this to the 1.2.1 milestone Dec 8, 2018
@ivangalkin ivangalkin self-assigned this Dec 8, 2018
@ivangalkin ivangalkin requested a review from guwirth December 8, 2018 16:15
@guwirth guwirth merged commit 518700d into SonarOpenCommunity:master Dec 8, 2018
@guwirth guwirth mentioned this pull request Dec 21, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guwirth guwirth guwirth approved these changes

Assignees

@ivangalkin ivangalkin

Labels
enhancement
Milestone
1.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@ivangalkin @guwirth