Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppVeyor build artifacts #1614

Merged
merged 1 commit into from
Dec 8, 2018
Merged

AppVeyor build artifacts #1614

merged 1 commit into from
Dec 8, 2018

Conversation

guwirth
Copy link
Collaborator

@guwirth guwirth commented Dec 6, 2018

Add an unique version number to build artefacts.

  • all snapshots have an unique version number now
  • possible to use the snapshots for releases without renaming them

This change is Reviewable

@guwirth guwirth added this to the 1.2.1 milestone Dec 6, 2018
@guwirth guwirth self-assigned this Dec 6, 2018
- replace SNAPSHOT with build number
Copy link
Contributor

@ivangalkin ivangalkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @guwirth, @jmecosta, @ivangalkin, and @Bertk)


appveyor.yml, line 87 at r1 (raw file):

REM

I am not a big MS batch expert, but what's the point in changing this line if it's disabled? maybe we could remove the line completely?

@guwirth
Copy link
Collaborator Author

guwirth commented Dec 8, 2018

REM

Like to keep it. This may work in future... #1597

@guwirth guwirth merged commit 3a2c5db into SonarOpenCommunity:master Dec 8, 2018
@guwirth guwirth mentioned this pull request Dec 21, 2018
@guwirth guwirth deleted the appveyor-build branch December 27, 2018 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants