clean-up Technical Debt

[guwirth]

• S00103
• S1258
• S00117
• S3415
• LeftCurlyBraceEndLineCheck
• S2131
• S1213
• S2333

---

This change is 

[ivangalkin]

Reviewed 56 of 56 files at r1.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @guwirth)

---

cxx-checks/src/main/java/org/sonar/cxx/checks/regex/FileHeaderCheck.java, line 75 at r1 (raw file):

Charset.forName("UTF-8");

This pattern repeats several time in our code. I believe, that using of named constants instead of lookup would be a better idea

import java.nio.charset.StandardCharsets;
...
private Charset charset = StandardCharsets.UTF_8;

---

cxx-checks/src/main/java/org/sonar/cxx/checks/regex/FileRegularExpressionCheck.java, line 63 at r1 (raw file):

Charset.forName("UTF-8");

same here and in more than 30 other places

---

cxx-squid/src/main/java/org/sonar/cxx/CxxAstScanner.java, line 253 at r1 (raw file):

    int max = min(lenOfB, lenOfA);

I believe, that every reader will suspect a mistake in this assignment. Why not to call the variable intersectionLength?

Besides that, the function intersectionConcatenate() might be useless since #1480. I might be wrong though.

[ivangalkin]

@guwirth sorry for the delay; A couple of (late) comments from my side.

[guwirth]

@ivangalkin thx for your feedback. There are another 666 open isues waiting to be closed :-) (https://sonarcloud.io/dashboard?id=org.sonarsource.sonarqube-plugins.cxx%3Acxx). Will have a look in one of the next PR.