Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regex refactoring 2 #1471

Merged
merged 1 commit into from
May 6, 2018
Merged

regex refactoring 2 #1471

merged 1 commit into from
May 6, 2018

Conversation

ivangalkin
Copy link
Contributor

@ivangalkin ivangalkin commented Apr 29, 2018 •
edited by SonarOpenCommunityAdmin
Loading

I used example from #1415 and could measure some spead-up (10%?)
The basic profiling with -agentlib:hprof=cpu=samples,depth=100 was
however not enough to find a root cause

This change is Reviewable

@ivangalkin
regex refactoring 2
244c69d 
* precompiled regex pattern are faster than String.split()
  (https://shipilev.net/talks/joker-Oct2014-string-catechism.pdf, from page 72)
* there are visitors, which use splitting for every ASTNode ->
  perceptible improvement

I used example from SonarOpenCommunity#1415 and could measure some spead-up (10%?)
The basic profiling with `-agentlib:hprof=cpu=samples,depth=100` was
however not enough to find a root cause
@guwirth guwirth added this to the 1.0 milestone May 5, 2018
@guwirth guwirth requested review from guwirth and Bertk May 5, 2018 06:56
@guwirth guwirth merged commit e88999f into SonarOpenCommunity:master May 6, 2018
@guwirth guwirth mentioned this pull request May 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guwirth guwirth guwirth approved these changes

@Bertk Bertk Awaiting requested review from Bertk

Assignees

@ivangalkin ivangalkin

Labels
enhancement
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ivangalkin @guwirth