fix loading of a href element #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it can happen, that this function will fail in case of <abrr> <a></a> etc or or other issues. i would say it is a good idea to do additional error checking so that $a->getAttribute will not throw exception when a is null.
|
@vavrecan Can you give me an example, when such a thing happens? |
|
Iirc If tag in source is <abbr> </a> or so |
Sommerregen
reviewed
Jul 9, 2018
There was a problem hiding this comment.
Hi @vavrecan,
I think what you actually mean is:
$a = $dom->getElementsByTagName('a');
if ($a->length == 0) {
return $match[0];
}
$a = $a->item(0);as there is no check yet in the code for "emptyness" in the code. However, If found a bug with <abbr>: obviously the regex is wrong and has to be <a(?:\s[^>]*)?>.*?</a>.
Can you check my changes in the develop branch?
Sommerregen
added a commit
that referenced
this pull request
Jul 9, 2018
|
Merged. Thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it can happen, that this function will fail in case of etc or or other issues. i would say it is a good idea to do additional error checking so that $a->getAttribute will not throw exception when a is null.