-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Directus CMS & new Academic Day impl #89
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Good job here. I spotted one bug and proposed solution, and later just few syntax propositions of mine.
I totally agree with reducing data invalidation on our (mobile) site. In my opinion informations that comes from API should be trusted, and if needed, corrected,on backend site :)
PS. please forgive me code marking here. Havent done any review before and still learing how this rocekt science works here
lib/features/academic_calendar_greeting/model/academic_calendar_data.dart
Show resolved
Hide resolved
lib/features/academic_calendar_greeting/model/academic_calendar_data.dart
Show resolved
Hide resolved
lib/features/academic_calendar_greeting/model/academic_week_exception.dart
Outdated
Show resolved
Hide resolved
lib/features/study_circle_details/models/contact_section_data.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I would also ask myself at least a question "why ?"
when it comes to these two random changes.
@mikolaj-jalocha I believe I've applied the fix for the equal dates bug - but in a slighlty different way, so defienetly check it out and tell me if you think this is ok now. Also I've replied about the map in Check it out and tell me if I can merge 🤓 ? |
LGTM 😎 |
Good job Mikołaj! |
Ported whole app to new Directus CMS API
New Academic Day implementation:
Graphql's cache's TTL is set to 0 in all DEBUG builds now (we're gonna need it like that)
BREAKING CHANGES:
.env
:mailto:
and all websites withhttps://
- I had deleted previous "invalindation" mechanism, cause we don't have any "LinkType" enum on the server. We can add this kind of smart pattern detection or something, but I'm not sure if this is worth itScreenshots of the new academic days' types:
Persistent issues (TODO):