-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobile 15 #36
Mobile 15 #36
Conversation
- added same padding between all sections - added small left side padding in every horizontally scrollable section - all buttons now have splash - unified section header - splash screen is now placeholder for every image - repositories are now grouped into separate folders - widget related only to specific sections are now grouped into separate folders - buttons on big_preview_card.dart now have lighter shadows - added padding to the bottom of the page
- added same padding between all sections - added small left side padding in every horizontally scrollable section - all buttons now have splash - unified section header - splash screen is now placeholder for every image - repositories are now grouped into separate folders - widget related only to specific sections are now grouped into separate folders - buttons on big_preview_card.dart now have lighter shadows - added padding to the bottom of the page - added shimmering effect as loading animation for my_cached_image.dart - added shimmering effect as loading animations for every widget in home screen
- added same padding between all sections - added small left side padding in every horizontally scrollable section - all buttons now have splash - unified section header - splash screen is now placeholder for every image - repositories are now grouped into separate folders - widget related only to specific sections are now grouped into separate folders - buttons on big_preview_card.dart now have lighter shadows - added padding to the bottom of the page - added shimmering effect as loading animation for my_cached_image.dart - added shimmering effect as loading animations for every widget in home screen
…e-15 # Conflicts: # lib/features/home_view/widgets/buildings_section/buildings_section.dart # lib/features/home_view/widgets/departments_section/department_section.dart # lib/features/home_view/widgets/news_section.dart # lib/widgets/big_preview_card.dart
- added same padding between all sections - added small left side padding in every horizontally scrollable section - all buttons now have splash - unified section header - splash screen is now placeholder for every image - repositories are now grouped into separate folders - widget related only to specific sections are now grouped into separate folders - buttons on big_preview_card.dart now have lighter shadows - added padding to the bottom of the page - added shimmering effect as loading animation for my_cached_image.dart - added shimmering effect as loading animations for every widget in home screen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all, the home screen looks really great now. Few notes or changes noted, always happy to discuss. Good work. 🦈
lib/features/home_view/widgets/buildings_section/buildings_section.dart
Outdated
Show resolved
Hide resolved
lib/features/home_view/widgets/countdown_widget/exam_session_countdown.dart
Outdated
Show resolved
Hide resolved
lib/features/home_view/widgets/departments_section/department_section.dart
Outdated
Show resolved
Hide resolved
lib/features/home_view/widgets/departments_section/department_section.dart
Show resolved
Hide resolved
lib/features/home_view/widgets/loading_widgets/big_scrollable_section_loading.dart
Outdated
Show resolved
Hide resolved
lib/features/home_view/widgets/buildings_section/buildings_section.dart
Outdated
Show resolved
Hide resolved
lib/features/home_view/widgets/departments_section/deparment_box.dart
Outdated
Show resolved
Hide resolved
lib/features/home_view/widgets/loading_widgets/scrollable_section_loading.dart
Show resolved
Hide resolved
…e Home Screen. - removed unnecessary imports - extracted and corrected some widgets
@simon-the-shark Thanks for the review. Changes are applied in the new commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! You can merge
Thanks for everything! |
#34
-all changes applied without:
8."wydział wydział" and background images probably should have less opacity (?). Ideally unify all source images to totally white and then add unified opacity in the app.