Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile 15 #36

Merged
merged 9 commits into from
Feb 20, 2024
Merged

Mobile 15 #36

merged 9 commits into from
Feb 20, 2024

Conversation

mikolaj-jalocha
Copy link
Member

#34

-all changes applied without:

8."wydział wydział" and background images probably should have less opacity (?). Ideally unify all source images to totally white and then add unified opacity in the app.

simon-the-shark and others added 7 commits January 24, 2024 18:57
- added same padding between all sections
- added small left side padding in every horizontally scrollable section
- all buttons now have splash
- unified section header
- splash screen is now placeholder for every image
- repositories are now grouped into separate folders
- widget related only to specific sections are now grouped into separate folders
- buttons on big_preview_card.dart now have lighter shadows
- added padding to the bottom of the page
- added same padding between all sections
- added small left side padding in every horizontally scrollable section
- all buttons now have splash
- unified section header
- splash screen is now placeholder for every image
- repositories are now grouped into separate folders
- widget related only to specific sections are now grouped into separate folders
- buttons on big_preview_card.dart now have lighter shadows
- added padding to the bottom of the page
- added shimmering effect as loading animation for my_cached_image.dart
- added shimmering effect as loading animations for every widget in home screen
- added same padding between all sections
- added small left side padding in every horizontally scrollable section
- all buttons now have splash
- unified section header
- splash screen is now placeholder for every image
- repositories are now grouped into separate folders
- widget related only to specific sections are now grouped into separate folders
- buttons on big_preview_card.dart now have lighter shadows
- added padding to the bottom of the page
- added shimmering effect as loading animation for my_cached_image.dart
- added shimmering effect as loading animations for every widget in home screen
…e-15

# Conflicts:
#	lib/features/home_view/widgets/buildings_section/buildings_section.dart
#	lib/features/home_view/widgets/departments_section/department_section.dart
#	lib/features/home_view/widgets/news_section.dart
#	lib/widgets/big_preview_card.dart
- added same padding between all sections
- added small left side padding in every horizontally scrollable section
- all buttons now have splash
- unified section header
- splash screen is now placeholder for every image
- repositories are now grouped into separate folders
- widget related only to specific sections are now grouped into separate folders
- buttons on big_preview_card.dart now have lighter shadows
- added padding to the bottom of the page
- added shimmering effect as loading animation for my_cached_image.dart
- added shimmering effect as loading animations for every widget in home screen
Copy link
Member

@simon-the-shark simon-the-shark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, the home screen looks really great now. Few notes or changes noted, always happy to discuss. Good work. 🦈

…e Home Screen.

- removed unnecessary imports
- extracted and corrected some widgets
@mikolaj-jalocha
Copy link
Member Author

@simon-the-shark Thanks for the review. Changes are applied in the new commit.

@mikolaj-jalocha mikolaj-jalocha linked an issue Feb 20, 2024 that may be closed by this pull request
Copy link
Member

@simon-the-shark simon-the-shark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! You can merge

@mikolaj-jalocha
Copy link
Member Author

Great! You can merge

Thanks for everything!

@mikolaj-jalocha mikolaj-jalocha merged commit 413e4e4 into main Feb 20, 2024
@mikolaj-jalocha mikolaj-jalocha deleted the mobile-15 branch February 20, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Mobile - 15] Unify home screen
2 participants