Feat/ add app's streak counter #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
simon-the-shark
commented
Oct 5, 2024
simon-the-shark
commented
mikolaj-jalocha
previously approved these changes
Oct 6, 2024
| class StreakStartRepository extends _$StreakStartRepository | ||
| with TimestampRepository { | ||
| @override | ||
| final storeKey = "__app_streak_counter__streak_start_stamp"; |
There was a problem hiding this comment.
What about parametrizing it in the config file?
There was a problem hiding this comment.
Maybe an overkill, but I thought about adding simple loading shimmer here (it's everywhere else)
There was a problem hiding this comment.
it should basically be almost instantenious - no actualy loading should be seen imo in this case (shared preferences should be already loaded)
simon-the-shark
force-pushed
the
feat/app-streak-counter
branch
from
a885036 to
5360e8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.