#221 - add cache support for map tiles #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-the-shark
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
LGTM!
- TTL of map cache is def enough
- yeah we use it indirectly with graphql package
- so just install app, enter it and then exit app, enter flight mode (no internet) and if map has still tiles on new offline enter then the caching works. -imo simpelst testing method
| @@ -38,7 +39,13 @@ class MapWidget<T extends GoogleNavigable> extends ConsumerWidget { | |||
| TileLayer( | |||
| urlTemplate: OpenStreetMapConfig.tileUrl, | |||
| userAgentPackageName: OpenStreetMapConfig.userAgent, | |||
| tileProvider: CancellableNetworkTileProvider(), | |||
| tileProvider: CachedTileProvider( | |||
There was a problem hiding this comment.
future note, on web we may want to use CancellableNetworkTileProvider instead of cached one - but only a future note
simon-the-shark
deleted the
feat/#221-add-cache-support-for-map-tiles
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added cachce support for map tiles.
nullpassed in place of directory path. Documentation says that if we use Hive already in the project, there's no need to provide it again. I guess that's correct in our situation.