Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/guide details enhancement #151

Merged
merged 3 commits into from
Aug 10, 2024
Merged

Conversation

simon-the-shark
Copy link
Member

Few small changes I've thought of:

  1. Introduced sliver resizing effect to cover photo
  2. introduced one common html widget for all app and changed answers to html widget
  3. changed backend widget of description to WYSIG editor
  4. increased padding a bit and changed font to one like in about us

Before

WhatsApp.Video.2024-08-10.at.00.07.26.mp4

After

WhatsApp.Video.2024-08-10.at.00.39.18.mp4

@simon-the-shark simon-the-shark added the enhancement New feature or request label Aug 9, 2024
@simon-the-shark simon-the-shark self-assigned this Aug 9, 2024
Copy link
Member

@mikolaj-jalocha mikolaj-jalocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sliver looks nice!

Just left one comment.

customStylesBuilder: context.customStylesBuilder,
onTapUrl: ref.launch,
),
child: HtmlWidget(text),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use here MyHtmlWidget?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes yes, this was the intension :P

@simon-the-shark simon-the-shark force-pushed the feat/guide-details-enhancement branch from a2a25be to 267db95 Compare August 10, 2024 07:38
@simon-the-shark simon-the-shark merged commit f68d9e5 into main Aug 10, 2024
2 checks passed
@simon-the-shark simon-the-shark deleted the feat/guide-details-enhancement branch August 10, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants