Does not compile

[bvboas]

Changing from dev to production gives the following error:

PHP Fatal error:  Declaration of Snowdog\Menu\Block\NodeType\AbstractNode::getHtml() must be compatible with Snowdog\Menu\Api\NodeTypeInterface::getHtml(Snowdog\Menu\Api\int $nodeId, Snowdog\Menu\Api\int $level) in /home/user/public_html/app/code/Snowdog/Menu/Block/NodeType/AbstractNode.php on line 20

[dawiddczaja]

Hello, I tried reproduce bug in CE and EE version but without effect. Which magento and magento2-menu version you have ?

[SilvanLaroo]

Hi,

I'm facing the same issue. I'm using Magento 2.1.7 and the latest version of your extension.

[mcjwsk]

@bvboas @SilvanLaroo fixed on develop branch. Please test.

[SilvanLaroo]

I've just installed the version from dev-develop, but got a similar error:
Warning: Uncaught Exception: Warning: Declaration of Snowdog\Menu\Block\NodeType\Category\Interceptor::isCurrentCategory($nodeId) should be compatible with Snowdog\Menu\Block\NodeType\Category::isCurrentCategory(int $nodeId) in

[mcjwsk]

@SilvanLaroo thanks but that's not directly related to this issue. I will open a separate issue for that.
Anyway please confirm the error reported here has been fixed, ok?

[SilvanLaroo]

It's related right? The problem is that Magento does not include Scalar Type hinting in the var/generation files.

[mcjwsk]

That's right. Magento Team fixed it here magento/magento2#6106 but it hasn't been merged into the master branch yet.
I created a separate task to remove all PHP7 type hints in our module: #10

[mcjwsk]

The fix has been merged into the develop branch (bd50cd2).