Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CALCEPH integration #85

Merged
merged 16 commits into from
Nov 9, 2024
Merged

CALCEPH integration #85

merged 16 commits into from
Nov 9, 2024

Conversation

attipaci
Copy link
Collaborator

@attipaci attipaci commented Nov 6, 2024

Provides optional ephemeris support via the CALCEPH C library in separate solsys-calceph.so[.1] / .a plugin libraries.

To enable, CALCEPH_SUPPORT must be set to 1 prior to the build (in the shell or in config.mk) and you must have access to the CALCEPH development files (C headers and unversioned libaries).

Added functions are:

  • int novas_use_calceph(t_calcephbin *eph) -- to specify and use ephemeris data via CALCEPH for minor bodies, and possibly also for major planets too, depending on further configuration.

  • int novas_use_calceph_planets(t_calcephbin *eph) -- to specify and use ephemeris data for major planets (and Sun, Moon, SSB), such as say JPL's DE440.

  • int novas_calceph_use_ids(enum novas_id_type idtype) -- to specify whether object.number in NOVAS_EPHEM_OBJECT type objects is a NAIF ID (default) or else a CALCEPH ID number of the Solar-system body.

To use the plugin, you must link your application with:

 -lsolsys-calceph

@attipaci attipaci added the enhancement New feature or request label Nov 6, 2024
@attipaci attipaci added this to the 1.2.0 milestone Nov 6, 2024
@attipaci attipaci self-assigned this Nov 6, 2024
@attipaci attipaci linked an issue Nov 6, 2024 that may be closed by this pull request
@attipaci attipaci force-pushed the calceph-integration branch 4 times, most recently from b7d3b79 to 5e4c30f Compare November 6, 2024 17:24
@attipaci
Copy link
Collaborator Author

attipaci commented Nov 6, 2024

Needs tests, CI, and coverage data...

@attipaci attipaci force-pushed the calceph-integration branch from 5e4c30f to f7d1302 Compare November 6, 2024 18:24
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.65%. Comparing base (e40fbcc) to head (41b6b51).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #85   +/-   ##
=======================================
  Coverage   99.64%   99.65%           
=======================================
  Files           7        8    +1     
  Lines        2843     2888   +45     
  Branches      551      554    +3     
=======================================
+ Hits         2833     2878   +45     
  Partials       10       10           
Flag Coverage Δ
unittests 99.65% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/naif.c 100.00% <100.00%> (ø)
src/novas.c 99.54% <100.00%> (+<0.01%) ⬆️
src/super.c 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4997c38...41b6b51. Read the comment docs.

@attipaci attipaci force-pushed the calceph-integration branch 9 times, most recently from ff2b9d3 to 9ad15db Compare November 7, 2024 11:19
@attipaci attipaci force-pushed the calceph-integration branch from 2e4aed0 to 94210ba Compare November 7, 2024 14:16
@attipaci attipaci force-pushed the calceph-integration branch 5 times, most recently from f3bfa6f to 47f3daa Compare November 8, 2024 10:29
@attipaci attipaci force-pushed the calceph-integration branch from 8f8ff85 to 1b27c46 Compare November 8, 2024 12:42
@attipaci attipaci force-pushed the calceph-integration branch from 91af13c to 495c4a0 Compare November 8, 2024 13:26
@attipaci attipaci force-pushed the calceph-integration branch from fbb84a8 to 90ae842 Compare November 8, 2024 19:03
@attipaci attipaci force-pushed the calceph-integration branch from 90ae842 to f4d36ef Compare November 8, 2024 19:05
@attipaci attipaci force-pushed the calceph-integration branch 11 times, most recently from 9bfe3d2 to aa26d30 Compare November 8, 2024 23:08
@attipaci attipaci force-pushed the calceph-integration branch 3 times, most recently from aa70f18 to 7f842d2 Compare November 9, 2024 11:00
@attipaci attipaci force-pushed the calceph-integration branch from 7f842d2 to 429874a Compare November 9, 2024 11:02
@attipaci attipaci merged commit 5082dca into main Nov 9, 2024
16 checks passed
@attipaci attipaci deleted the calceph-integration branch November 9, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for CALCEPH
1 participant