Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tt2tdb() period and improve precision #35

Merged
merged 2 commits into from
Jun 29, 2024
Merged

Fix tt2tdb() period and improve precision #35

merged 2 commits into from
Jun 29, 2024

Conversation

attipaci
Copy link
Collaborator

Another SuperNOVAS 1.0 oops. Beyond fixing the scaling tt2tdb() now uses the same series tdb2tt() series of the original NOVAS C.

@attipaci attipaci added the bug Something isn't working label Jun 29, 2024
@attipaci attipaci added this to the 1.1.0 milestone Jun 29, 2024
@attipaci attipaci self-assigned this Jun 29, 2024
Copy link

codecov bot commented Jun 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.65%. Comparing base (20564a5) to head (212abc8).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
- Coverage   98.65%   98.65%   -0.01%     
==========================================
  Files           3        3              
  Lines        2004     2003       -1     
  Branches      378      378              
==========================================
- Hits         1977     1976       -1     
  Misses          9        9              
  Partials       18       18              
Flag Coverage Δ
unittests 98.65% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/novas.c 98.44% <100.00%> (-0.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c387ba...212abc8. Read the comment docs.

@attipaci attipaci merged commit 64ffa97 into main Jun 29, 2024
10 checks passed
@attipaci attipaci deleted the fix-tt2tdb branch June 29, 2024 12:00
@attipaci attipaci linked an issue Jun 30, 2024 that may be closed by this pull request
@attipaci attipaci changed the title tt2tdb() had a wrong scaling in the period Fix tt2tdb() period and improve precision Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tt2tdb() had wrong period
1 participant