Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New high-level, elegant, and efficient observer frame approach #33

Merged
merged 61 commits into from
Jul 4, 2024

Conversation

attipaci
Copy link
Collaborator

@attipaci attipaci commented Jun 25, 2024

A new high-level, more elegant, and more efficient approach for coordinate calculations, using observer frames, which represent an observer location and time of observation. Upon configuring the frame, it precalculates the necessary quantities for transformations so they may be re-used repeatedly, with minimal added computational cost, e.g. to calculate the positions of many objects in that observing frame, as well as to allow converting between coordinate reference systems with ease.

@attipaci attipaci added the enhancement New feature or request label Jun 25, 2024
@attipaci attipaci added this to the 1.1.0 milestone Jun 25, 2024
@attipaci attipaci self-assigned this Jun 25, 2024
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 99.75460% with 2 lines in your changes missing coverage. Please review.

Project coverage is 99.02%. Comparing base (9e55aaf) to head (8888db0).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
+ Coverage   98.70%   99.02%   +0.32%     
==========================================
  Files           3        6       +3     
  Lines        2004     2662     +658     
  Branches      378      499     +121     
==========================================
+ Hits         1978     2636     +658     
  Misses          9        9              
  Partials       17       17              
Flag Coverage Δ
unittests 99.02% <99.75%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/refract.c 100.00% <100.00%> (ø)
src/timescale.c 100.00% <100.00%> (ø)
src/frames.c 99.74% <99.74%> (ø)
src/novas.c 98.62% <99.57%> (+0.12%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e55aaf...8888db0. Read the comment docs.

@attipaci attipaci changed the title New high-level, elegant, and efficient observer frames approach New high-level, elegant, and efficient observer frame approach Jun 25, 2024
@attipaci attipaci force-pushed the frames branch 2 times, most recently from 9dc3433 to fc6b822 Compare June 29, 2024 12:01
@attipaci attipaci force-pushed the frames branch 2 times, most recently from 23bee11 to cee761a Compare July 3, 2024 09:24
@attipaci attipaci merged commit c2c6886 into main Jul 4, 2024
10 checks passed
@attipaci attipaci deleted the frames branch July 4, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant