Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grav_undef() to gravitationally unbend observed light #32

Merged
merged 4 commits into from
Jun 19, 2024
Merged

Conversation

attipaci
Copy link
Collaborator

The inverse function for grav_def().

Also:

  • Fix up test cases but initializing all data to avoid unreproducible behavior in tests.
  • Use precompiler constants to define max number of iterations for inverse methods.

@attipaci attipaci added the enhancement New feature or request label Jun 18, 2024
@attipaci attipaci added this to the 1.1.0 milestone Jun 18, 2024
@attipaci attipaci self-assigned this Jun 18, 2024
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 76.19048% with 5 lines in your changes missing coverage. Please review.

Project coverage is 98.65%. Comparing base (7e6f810) to head (1dfa376).

Current head 1dfa376 differs from pull request most recent head 199af4c

Please upload reports for the commit 199af4c to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
- Coverage   98.78%   98.65%   -0.14%     
==========================================
  Files           3        3              
  Lines        1983     2004      +21     
  Branches      370      378       +8     
==========================================
+ Hits         1959     1977      +18     
- Misses          7        9       +2     
- Partials       17       18       +1     
Flag Coverage Δ
unittests 98.65% <76.19%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/novas.c 98.44% <76.19%> (-0.16%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e6f810...199af4c. Read the comment docs.

@attipaci attipaci merged commit 97963f9 into main Jun 19, 2024
1 check passed
attipaci added a commit that referenced this pull request Jun 23, 2024
@attipaci attipaci deleted the grav_undef branch June 26, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant