Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rad_vel() does not always include relativistic corrections for moving observer #50

Closed
attipaci opened this issue Aug 1, 2024 · 0 comments · Fixed by #48
Closed

rad_vel() does not always include relativistic corrections for moving observer #50

attipaci opened this issue Aug 1, 2024 · 0 comments · Fixed by #48
Assignees
@attipaci
Labels
bug Something isn't working
Milestone
1.1.0

Comments

@attipaci
Copy link
Collaborator

attipaci commented Aug 1, 2024 •
edited
Loading

The NOVAS C 3.1 implementation of rad_vel() applied relativistic corrections for a moving observer conditional on applying relativistic gravitational corrections (for Sun and/or Earth potential) for observer. However, it seems more reasonable that the corrections for a (fast) moving observer should be applied independently of the (optional) gravitational corrections. This affects SuperNOVAS releases prior to v1.1 also.
@attipaci attipaci added the bug Something isn't working label Aug 1, 2024
@attipaci attipaci added this to the 1.1.0 milestone Aug 1, 2024
@attipaci attipaci self-assigned this Aug 1, 2024
@attipaci attipaci linked a pull request Aug 1, 2024 that will close this issue
v1.1.0 release composition (part 2) #48
Merged
attipaci added a commit that referenced this issue Aug 1, 2024
@attipaci
Issues #50 and #51: rad_vel() handling of relativistic corrections
de27f70
@attipaci attipaci mentioned this issue Aug 1, 2024
Merged
attipaci added a commit that referenced this issue Aug 1, 2024
@attipaci
v1.1.0 release composition (part 2) (#48)
df7c5d1 
* v1.1.0 release composition (part 2)

* Proper accounting of gravitational bending for radial velocities, and more.

* Fix ccpcheck error in last commit

* Another attempt to get deflected radial velocities right...

* Tweaks and fill tesing holes

* doxygen edits

* Switch logic order in radial velocity calculation

* Add rad_vel2() for radial velocity calculation with gravitational deflection.

* Tweaks, clean up...

* State typical (max.) radial velocity error from old calculation.

* rad_vel() doxygen edits

* Issues #50 and #51: rad_vel() handling of relativistic corrections

* Issue #51: Tweak fix.

* doxygen tweaks

* Small CHANGELOG edit

* Keep -devel in version for now...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@attipaci attipaci

Labels
bug Something isn't working
Projects
None yet
Milestone
1.1.0
Development

Successfully merging a pull request may close this issue.

v1.1.0 release composition (part 2) Smithsonian/SuperNOVAS
1 participant
@attipaci