Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in cel2ter() with CIRS input #45

Closed
attipaci opened this issue Jul 28, 2024 · 0 comments · Fixed by #46
Closed

Bug in cel2ter() with CIRS input #45

attipaci opened this issue Jul 28, 2024 · 0 comments · Fixed by #46
Assignees
@attipaci
Labels
bug Something isn't working
Milestone
1.1.0

Comments

@attipaci
Copy link
Collaborator

attipaci commented Jul 28, 2024 •
edited
Loading

When cel2ter() was called with CIRS coordinates (erot = EROT_ERA, class = NOVAS_DYNAMICAL_CLASS), and distinct inputand output coordinates, the output was not properly calculated. The bug also affects the SuperNOVAS cirs_to_itrs() function. The bug affects all prior SuperNOVAS releases.
@attipaci attipaci added the bug Something isn't working label Jul 28, 2024
@attipaci attipaci added this to the 1.1.0 milestone Jul 28, 2024
@attipaci attipaci self-assigned this Jul 28, 2024
@attipaci attipaci pinned this issue Jul 28, 2024
@attipaci attipaci mentioned this issue Jul 28, 2024
Merged
@attipaci attipaci linked a pull request Jul 28, 2024 that will close this issue
Fix cel2ter() bug with CIRS input, and added tests #46
Merged
attipaci added a commit that referenced this issue Jul 28, 2024
@attipaci
Changelog entry for fix to Issue #45.
50d1345
@attipaci attipaci changed the title Bug in cel2ter with CIRS input Bug in cel2ter() with CIRS input Jul 28, 2024
attipaci added a commit that referenced this issue Jul 28, 2024
@attipaci
Fix cel2ter() bug with CIRS input, and added tests (#46)
f593b73 
* Fix cel2ter() bug  with CIRS input, and added tests

* Changelog entry for fix to Issue #45.

* Minor simplification in ter2cel()

* cel2ter: Do not set NAN if error (since it's not done consistently...)
@attipaci attipaci unpinned this issue Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@attipaci attipaci

Labels
bug Something isn't working
Projects
None yet
Milestone
1.1.0
Development

Successfully merging a pull request may close this issue.

Fix cel2ter() bug with CIRS input, and added tests Smithsonian/SuperNOVAS
1 participant
@attipaci