-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MDNS library with query support #2237
Conversation
d74540c
to
58e8797
Compare
Like the SSDP server the Finder requires two UDP ports, one to listen and another to send. Few things to note here:
The responder part should be rewritten along the same lines as the finder, sharing common code, etc. That will provide a common code base for all architectures and provide more flexiblility. (Another PR) |
58e8797
to
ade4efa
Compare
@mikee47 Can you check the failing CI build? |
ade4efa
to
f9ab836
Compare
Yep, just reverting some changes which don't work on ancient compiler. |
ef2b5f6
to
c70f189
Compare
OK, so running on ESP8266 responses come in OK but cannot see the outgoing queries in Wireshark. I'm using the SSDP server code as a reference and failing to spot the problem! |
c70f189
to
e0f2782
Compare
@mikee47 Ping me when this PR is ready for testing. |
@slaff OK ready for testing. |
@slaff This has grown a little, perhaps it should be in a separate library? |
b9f346b
to
e33e30d
Compare
I've been unable to get discovery working in host emulator under Linux. Likely I need to adjust the bridge configuration - any ideas? |
NB. Working in WSL2, so perhaps related. Here's my network info:
|
@mikee47 This PR looks good to me. Do you plan to add more changes or I should merge it as it is? |
@slaff All done thanks |
@slaff Spotted one minor bug in the code, further updates will arrive in responder |
…orkPacket` and `HostPacket` Old compilers require constructor for inherited classes
Need ANY, SOA spotted during testing
Split names by identifying location of protocol Validate length in getDataLength() call
Ping me when ready. |
befd3f9
to
fb30f5a
Compare
@slaff OK rebased/tidied, plus relevant commits from the responder branch. |
0c6409d
to
50f8714
Compare
Add
Basic_Mdns
sample to demonstrate usageTODO: