-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ModbusMaster fixes #2059
Merged
Merged
ModbusMaster fixes #2059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ite(). Add NUL character to ensure that all data is sent before the line is released
slaff
reviewed
Apr 14, 2020
Sming/Libraries/ModbusMaster/samples/generic/app/application.cpp
Outdated
Show resolved
Hide resolved
Sming/Libraries/ModbusMaster/samples/generic/app/application.cpp
Outdated
Show resolved
Hide resolved
slaff
reviewed
Apr 14, 2020
mikee47
approved these changes
Apr 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine! Thanks.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the following fixes to ModbusMaster:
0. ModbusMaster is patched to use single
_serial->write()
to send the whole message instead of 'for loop'.mbLoop()
the variableresult
was used instead ofmbResult
when reporting the error code.result
is removed and the propermbResult
is used.mbLogReceive()
debug message of the RX ADU is added.mbLogTransmit
ADU is changed to "TX ADU" to clarify the message.