Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModbusMaster fixes #2059

Merged
merged 6 commits into from
Apr 18, 2020
Merged

ModbusMaster fixes #2059

merged 6 commits into from
Apr 18, 2020

Conversation

kmihaylov
Copy link
Contributor

This PR introduces the following fixes to ModbusMaster:
0. ModbusMaster is patched to use single _serial->write() to send the whole message instead of 'for loop'.

  1. ModbusMaster is now patched so as to send single NUL character after the message in order to ensure TX line release after the whole message is sent.
  2. Delays in the generic sample are commented out, but left for reference (the example works well without the delays).
  3. In mbLoop() the variable result was used instead of mbResult when reporting the error code. result is removed and the proper mbResult is used.
  4. In mbLogReceive() debug message of the RX ADU is added.
  5. In mbLogTransmit ADU is changed to "TX ADU" to clarify the message.

@slaff slaff requested a review from mikee47 April 14, 2020 13:33
@slaff slaff added this to the 4.1.1 milestone Apr 14, 2020
Copy link
Contributor

@mikee47 mikee47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine! Thanks.

@slaff slaff merged commit 5f3d8f7 into SmingHub:develop Apr 18, 2020
@slaff slaff removed the 3 - Review label Apr 18, 2020
@slaff slaff mentioned this pull request May 8, 2020
4 tasks
@kmihaylov kmihaylov mentioned this pull request Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants