Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated DNSServer. Use DnsServer instead. #1915

Merged
merged 2 commits into from
Oct 27, 2019
Merged

Deprecated DNSServer. Use DnsServer instead. #1915

merged 2 commits into from
Oct 27, 2019

Conversation

slaff
Copy link
Contributor

@slaff slaff commented Oct 27, 2019

No description provided.

@slaff slaff added this to the 4.0.0 milestone Oct 27, 2019
@slaff slaff force-pushed the fix/rename-dnsserver branch from 23be692 to 879f7d7 Compare October 27, 2019 11:20
@slaff slaff force-pushed the fix/rename-dnsserver branch from 879f7d7 to ad0a495 Compare October 27, 2019 11:22
@slaff slaff merged commit 00701c5 into SmingHub:develop Oct 27, 2019
@mikee47
Copy link
Contributor

mikee47 commented Oct 28, 2019 •
edited
Loading

@slaff This breaks Windows as it cannot distinguish between DNSServer.h and DnsServer.h. Probably worth a note in the upgrade docs.

@slaff
Copy link
Contributor Author

slaff commented Oct 28, 2019

This breaks Windows as it cannot distinguish between DNSServer.h and DnsServer.h

Hm... Strange how appveyor did not detect that. That will mean that also rBootOutput... and RbootOutput.. should have the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@slaff @mikee47 @slav-at-attachix