Fix custom heap #1745
Merged
Fix custom heap #1745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mikee47 Did you try this PR on a real device? |
|
Yes, works on NodeMCU. I've never got the custom heap to work, until I found the reason today. It's odd, though, it must have worked at some point but can't find when that was; candidate for LTS I guess? |
slaff
pushed a commit
to slaff/Sming
that referenced
this pull request
Jul 7, 2019
* Fix custom heap * Update umm_malloc to latest version * Add support for poison checking
slaff
added a commit
that referenced
this pull request
Jul 7, 2019
slaff
pushed a commit
to slaff/Sming
that referenced
this pull request
Jul 14, 2019
* Fix custom heap * Update umm_malloc to latest version * Add support for poison checking
This was referenced Dec 10, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should call umm_malloc, etc. not malloc().
Update to latest version of umm_malloc, and add support for poison checking.