Add support for escaped URLs #1642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stead Also copy `postParams` as that is probably intended Deprecate `HttpRequest` copy assignment operator Define appropriate copy constructors for `HttpHeaders` and `HttpParams` Using copy operator on headers unsafe (its' private in HashMap), using setMultiple() will work as expected.
…dise URL schemes Rename `Protocol` to `Scheme` Common schemes defined in table with default port numbers Replace use of ad-hoc names with `URI_SCHEME_*` Add support for URL fragments Add constructor to `Url` with individual components Provide implicit `String()` operator for `Url` Add `getRelativePath()` and `getFileName()` to simplify application code
Hm... I guess I should change the next release version from 3.7.2. to 3.8.0. There are already a lot of good improvements and deprecations in it to be treated as a minor release. |
slaff
reviewed
Feb 27, 2019
| this->url.Port = 465; | ||
| } | ||
| if(this->url.Port == 0) { | ||
| this->url.Port = isSecure ? 465 : 25; |
There was a problem hiding this comment.
Maybe you can use URI_SCHEME_MAP instead of hard-coding the ports?
slaff
reviewed
Feb 27, 2019
|
|
||
| client.connect(URL(dsn)); |
There was a problem hiding this comment.
I guess this PR is almost ready. Just the Readme.md file needs an update.
|
@mikee47 Is the PR ready and tested or you plan to add something more? |
|
@slaff OK, that's everything. I wanted to include an example somewhere for alternative methods of URL construction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revise
HttpRequestcopy constructorpostParamsin copyHttpRequestcopy assignment operatorHttpHeadersandHttpParamsRevise
URLandHttpParamsto support escaped textURLtoUrl- deprecateURLlibyuarelAdd support for common URL schemes
ProtocoltoSchemeas per RFCURI_SCHEME_*Other additions
Urlwith individual componentsString()operator forUrl(useful for print, etc.)getRelativePath()andgetFileName()to simplify application codeHttpBodyParser()to un-escape parameter data