StreamTransformer improvements #1593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaff
reviewed
Feb 5, 2019
| { | ||
| base64_init_encodestate(&state, CHARS_PER_LINE); | ||
|
|
||
| transformCallback = std::bind(&Base64OutputStream::encode, this, std::placeholders::_1, std::placeholders::_2, |
There was a problem hiding this comment.
Note: transformCallback retained, but no longer required by framework; could deprecate and make
transforma pure virtual method
Can you add that information as comments in the code? Ex:
/**
* ...
* @deprecated
*/
StreamTransformerCallback transformCallback __attribute__ ((deprecated)) = nullptr;
mikee47
changed the title
Change `transform` to return `size_t` instead of `int`, and make input parameter `const`. Note: transformCallback retained, but no longer required by framework; could deprecate and make `transform` a pure virtual method
Remove use of strlen Replace `ets_sprintf` with `m_snprintf`
… one Also move constructor/destructor code into header
mikee47
force-pushed
the
feature/StreamTransformer_improvements
branch
from
4e690c8 to
6d667b7
Compare
mikee47
added a commit
to mikee47/Sming
that referenced
this pull request
Feb 6, 2019
* Add virtual `transform` method to `StreamTransformer` class Change `transform` to return `size_t` instead of `int`, and make input parameter `const`. Note: transformCallback retained, but no longer required by framework; could deprecate and make `transform` a pure virtual method * Use `hexchar` function in `QuotedPrintableOutputStream` * Optimise ChunkedStream transform routine Remove use of strlen Replace `ets_sprintf` with `m_snprintf` * Add new constructor without callback parameter, and deprecate the old one Also move constructor/destructor code into header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add virtual
transformmethod toStreamTransformerclass, optimiseQuotedPrintableOutputStreamandChunkedStream.transformCallback retained, but no longer required by framework; could deprecate and make
transforma pure virtual method?